Processing model re-write based on MutationObserver. #47
Conversation
|
@domenic, PTAL and see if this addresses your concerns with the processing model. |
| text: DOMHighResTimeStamp; type: typedef; urlPrefix: http://www.w3.org/TR/hr-time/ | ||
| text: margin; type: attribute; url: http://www.w3.org/TR/CSS21/box.html#propdef-margin | ||
| text: length; type: attribute; url: http://www.w3.org/TR/css3-values/#lengths | ||
| urlPrefix: http://www.w3.org/TR/hr-time/; type: typedef; text: DOMHighResTimeStamp |
There was a problem hiding this comment.
Drive-by comment: prefer EDs to TRs. Also Web IDL 1 is dead; link to http://heycam.github.io/webidl/ instead.
There was a problem hiding this comment.
Sure, will update the webidl link.
When I look for these specs, the TRs seem to be what turns up. Were there ones in particular you had in mind?
There was a problem hiding this comment.
TRs have an unfortunate amount of google-juice, it's true. But they are outdated and should not be used as a basis for implementations. So, everywhere I see /TR/ in this list, it's better to navigate to that URL and click the "editor's draft" link, and use that instead.
|
Looking very good over all. This model is much easier for me to understand at least. I hope it doesn't mismatch the implementation too much. But it definitely clarifies a lot of things. Thanks for taking the time. |
| callback IntersectionObserverCallback = void (sequence<IntersectionObserverEntry> entries, IntersectionObserver observer) | ||
| </pre> | ||
| This callback will be invoked when there are changes to <i>target</i>'s intersection with <i>root</i>, as per the <a>processing model</a>. | ||
| <h3 id='2-1-intersection-observer-callback'> |
There was a problem hiding this comment.
Don't put section numbers in the ID. If you ever move/add/delete sections, you'll either have to change the ID (bad) or have the number be wrong (bad).
| list of idle request callbacks</a> with an appropriate | ||
| <li>If <i>unit</i>'s <a>IntersectionObserverTaskQueued</a> flag is set | ||
| to true, return.</li> | ||
| <li>Set <i>unit<\i>'s <a>IntersectionObserverTaskQueued</a> flag to |
| text: length; type: attribute; url: http://www.w3.org/TR/css3-values/#lengths | ||
| urlPrefix: http://www.w3.org/TR/hr-time/; type: typedef; text: DOMHighResTimeStamp | ||
| url: http://www.w3.org/TR/CSS21/box.html#propdef-margin; type: attribute; text: margin | ||
| url: http://www.w3.org/TR/css3-values/#lengths; type: attribute; text: length |
There was a problem hiding this comment.
Similarly, "length" is not an IDL attribute. It look like you want the <length> production - autolink that with <<length>>.
|
Thanks for the reviews. Anything else outstanding, or does this look good to merge now? |
|
This looks great! Thanks very much for your attention to detail. This is a really solid spec now from my perspective. (Which, admittedly, is more focused on general spec integration than on the domain-specific issues.) |
Processing model re-write based on MutationObserver.
|
Thanks! |
Fixes #35
Fixes #43