Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct flag type on LB proxy protocol #436

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Set correct flag type on LB proxy protocol #436

merged 2 commits into from
Apr 2, 2024

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Apr 2, 2024 •
edited
Loading

Description

Fix flag error on proxy-protocol flag for load balancer create

Related Issues

Fixes #435

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the regression Something that worked doesn't work after changes label Apr 2, 2024
@optik-aper optik-aper self-assigned this Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

christhemorse
christhemorse approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@christhemorse christhemorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyb

@optik-aper optik-aper merged commit 37b271d into vultr:master Apr 2, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christhemorse christhemorse christhemorse approved these changes

Assignees

@optik-aper optik-aper

Labels
regression Something that worked doesn't work after changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Proxy protocol flag error on load balancer create
2 participants
@optik-aper @christhemorse