Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate pagination metadata nil pointer checks #410

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

PaulSonOfLars
Copy link
Contributor

@PaulSonOfLars PaulSonOfLars commented Feb 25, 2024

Description

Consolidate pagination metadata nil pointer checks, fixing a panic in the region availability lists (#408)

Related Issues

Fixes #408

Checklist:

  • [Y] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [Y] Have you linted your code locally prior to submission?
  • [Y] Have you successfully ran tests with your changes locally?

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @PaulSonOfLars, Action: pull_request_target

@optik-aper optik-aper self-requested a review February 26, 2024 19:20
@optik-aper optik-aper added the enhancement New feature or request label Feb 26, 2024
@optik-aper
Copy link
Member

@PaulSonOfLars I like what you're doing here. Thanks for submitting the PR. I'm gonna look at this more closely and think it through. It's probably going to need a rebase once my PR goes in, so if you want to hold off to push the lint fixes until then, that'd be swell.

@PaulSonOfLars
Copy link
Contributor Author

@optik-aper no problem!
Sure thing, let me know when your PR is in and I'll rework this one

@optik-aper
Copy link
Member

Just merged it!

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @PaulSonOfLars, Action: pull_request_target

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @PaulSonOfLars, Action: pull_request_target

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @PaulSonOfLars, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little redundant but I think this is a good safety mechanism to check for nil structs. I'm merging it and might tweak it in the future. Thanks for the PR

@optik-aper optik-aper merged commit 1fcbd72 into vultr:master Feb 27, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Listing region availabilities causes a panic
2 participants