Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

394 - use read-write flag instead #395

Conversation

biondizzle
Copy link
Contributor

Description

fixes issue where read-write flag wasn't being honored

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@biondizzle biondizzle linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 1, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v2	[no test files]

Pusher: @biondizzle, Action: pull_request_target

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@optik-aper optik-aper merged commit 6a58e4b into master Feb 1, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Feb 1, 2024
@optik-aper optik-aper deleted the 394-bug-read_write-isnt-being-passed-on-docker-credentials-create branch March 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - read_write isn't being passed on Docker Credentials Create
2 participants