Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DatabaseUpdate VPCID to pointer for empty values #270

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

christhemorse
Copy link
Contributor

Description

Managed Database updates were failing to send an empty string to the Vultr API to detach VPCs, so this PR converts it into a pointer so it can safely be omitted, empty string, or VPCID string as the situation dictates.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the bug Something isn't working label Oct 24, 2023
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@optik-aper optik-aper merged commit a914d97 into vultr:master Oct 24, 2023
6 checks passed
@optik-aper optik-aper mentioned this pull request Oct 24, 2023
3 tasks
@christhemorse christhemorse deleted the fix-dbaas-vpc-detach branch October 27, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants