Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters from database update request #247

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Remove unused parameters from database update request #247

merged 1 commit into from
Apr 27, 2023

Conversation

christhemorse
Copy link
Contributor

Description

Database Engine and Database Engine Version are not usable in the update endpoint but were mistakenly included in the request object. This PR removes those.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the bug Something isn't working label Apr 20, 2023
optik-aper
optik-aper approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@optik-aper optik-aper merged commit 174d41c into vultr:master Apr 27, 2023
@christhemorse christhemorse deleted the dbaas-update-fix branch April 27, 2023 18:39
@optik-aper optik-aper mentioned this pull request Jun 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christhemorse @optik-aper