Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remov omitempty on domain records name #120

Merged
merged 5 commits into from
Jan 4, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Jan 4, 2021

Description

If you try to create a DNS record that doesn't have a name the omitempty we currently have won't get passed to the API which causes issues.

Related Issues

vultr/terraform-provider-vultr#105

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #120 (fe19cd6) into master (8c2f970) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   49.14%   49.14%           
=======================================
  Files          23       23           
  Lines        1168     1168           
=======================================
  Hits          574      574           
  Misses        348      348           
  Partials      246      246           
Impacted Files Coverage Δ
domain_records.go 45.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2f970...fe19cd6. Read the comment docs.

@ddymko ddymko merged commit 758ce41 into vultr:master Jan 4, 2021
@ddymko ddymko mentioned this pull request Jan 4, 2021
3 tasks
@ddymko ddymko deleted the domain-records-name branch September 22, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants