Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches for user + reserved ip #112

Merged
merged 1 commit into from
Nov 27, 2020
Merged

patches for user + reserved ip #112

merged 1 commit into from
Nov 27, 2020

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Nov 24, 2020

Description

Looks like there were a few issues that got past testing

Related Issues

n/a

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #112 (5f58265) into master (16d8ff3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   48.96%   49.00%   +0.04%     
==========================================
  Files          23       23              
  Lines        1160     1161       +1     
==========================================
+ Hits          568      569       +1     
  Misses        347      347              
  Partials      245      245              
Impacted Files Coverage Δ
user.go 52.94% <ø> (ø)
reserved_ip.go 52.00% <100.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d8ff3...5f58265. Read the comment docs.

@ddymko ddymko marked this pull request as ready for review November 25, 2020 14:55
@ddymko ddymko merged commit ced0bc4 into vultr:master Nov 27, 2020
@ddymko ddymko mentioned this pull request Nov 30, 2020
3 tasks
@ddymko ddymko deleted the v2-patches branch September 22, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants