feat: add the snapshot sync for v2 store #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetVersion rename to databucket, indexbucket
- GetVersion - migration (StoreUpgrades) - flat.Store query uses getversion
roysc
requested changes
Dec 14, 2021
|
@roysc I address the pr comments, Can you please look into the last commit |
|
@roysc I addressed the pr comments |
roysc
reviewed
Dec 14, 2021
roysc
reviewed
Dec 14, 2021
store/v2/root/snapshot_test.go
Outdated
| // checking snapshot restoring for store with existed schema and without existed versions | ||
| target3 := newMultiStore(t, memdb.NewDB(), 4) | ||
| // checking snapshot restoring for store with existed schema and without existing versions | ||
| target3 := newMultiStore(t, memdb.NewDB(), 0) |
There was a problem hiding this comment.
this should be non-zero, and the above 0
i-norden
approved these changes
Dec 14, 2021
| "bufio" | ||
| "compress/zlib" | ||
| "fmt" | ||
| prefixdb "github.com/cosmos/cosmos-sdk/db/prefix" |
There was a problem hiding this comment.
Let's order these imports
std lib
external deps
local deps
gsk967
changed the base branch from
roysc/adr-040-create-rootstore
to
master
|
@i-norden I created new pull request (cosmos#10794) to cosmos-sdk master branch Can i close this pull request and I already added your comment changes to pull request |
|
@gsk967 perfect, thanks! Yeah let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State Sync for V2 Store (ADR 40)
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change