Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): nested css supports atrule and comment #11899

Merged
merged 11 commits into from
Sep 13, 2024

Conversation

linzhe141
Copy link
Contributor

close #11896

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11899

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11899

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11899

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11899

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11899

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11899

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11899

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11899

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11899

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11899

vue

pnpm add https://pkg.pr.new/vue@11899

commit: 72857e7

@linzhe141 linzhe141 changed the title fix(compiler-sfc): nested css supports atrule fix(compiler-sfc): nested css supports atrule and comment Sep 12, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 12, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added the ready for review This PR requires more reviews label Sep 12, 2024
@@ -286,5 +282,22 @@ function isSpaceCombinator(node: selectorParser.Node) {
return node.type === 'combinator' && /^\s+$/.test(node.value)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave newlines between functions.

@yyx990803 yyx990803 merged commit 0e7bc71 into vuejs:main Sep 13, 2024
13 checks passed
@linzhe141 linzhe141 deleted the fix-sfc-style-nested-css branch September 19, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ queries in scoped nested CSS lack nesting selector
4 participants