Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): fix side effect computed dirty level changed unexpected #11183

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

Doctor-wu
Copy link
Member

thanks to @wanghanzhen for resetTracking and test case

close #11181, #11169

@Doctor-wu
Copy link
Member Author

/ecosystem-ci run

@Doctor-wu Doctor-wu changed the title fix(reactivity): fix side effect computed dirty level fix(reactivity): fix side effect computed dirty level changed unexpected Jun 20, 2024
@vue-bot
Copy link
Contributor

vue-bot commented Jun 20, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@wanghanzhen
Copy link

Excellent job! I tried it and it works fine in my project.

@Jallasia
Copy link

Thx indeed, we cannot update to current version because of this issue, nice to see that it will be fixed very soon thx to you :-)

@yyx990803 yyx990803 merged commit 3bd79e3 into vuejs:main Jun 22, 2024
11 checks passed
@Doctor-wu Doctor-wu deleted the fix-side-effect-computed branch June 22, 2024 16:34
yyx990803 added a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with side-effect computed will cause an infinite loop when it returns different values in each run
5 participants