Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom envelope key option for server #1208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gamzeoguz
Copy link

No description provided.

@w666 w666 self-requested a review August 20, 2024 07:45
@w666
Copy link
Collaborator

w666 commented Aug 20, 2024

I rebased this branch so it has the latest changes and to run tests.

src/server.ts Outdated Show resolved Hide resolved
@w666
Copy link
Collaborator

w666 commented Aug 20, 2024

Also, seems like error responses also should contain custom key

<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
  xmlns:tns="http://example.com/stockquote.wsdl" xmlns:xsd1="http://example.com/stockquote.xsd">
  <soapenv:Body>
    <soap:Fault>
      <soap:Code>
        <soap:Value>SOAP-ENV:Server</soap:Value>
        <soap:Subcode>
          <soap:Value>InternalServerError</soap:Value>
        </soap:Subcode>
      </soap:Code>
      <soap:Reason>
        <soap:Text>Error: Failed to parse the SOAP Message body</soap:Text>
      </soap:Reason>
    </soap:Fault>
  </soapenv:Body>
</soapenv:Envelope>

@w666
Copy link
Collaborator

w666 commented Aug 20, 2024

Pushed changes to tests, but they still do not work as request is not valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants