Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names only in soap messages. #1205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

alex-eri
Copy link

@alex-eri alex-eri commented Dec 6, 2022

Without namespace check this function fails with Exception has occurred: TypeError: Cannot read properties of undefined (reading 'description') if Message>Body tags deepper inside answer.

Copy link

@pestig pestig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a same problem with deep Body tag. It's fixed my problem also.

@w666
Copy link
Collaborator

w666 commented Jul 17, 2024

Hi @alex-eri @pestig

I am happy to merge it and include into next release, it just requires a test. If you can add one that would be great.

@w666 w666 self-requested a review August 7, 2024 09:22
Copy link
Collaborator

@w666 w666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test

Fails with `Exception has occurred: TypeError: Cannot read properties of undefined (reading 'description')` if Message>Body tags deepper inside answer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants