Bugfix: Fix parsing issue for queue policies targeted at quorum queues #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmybigcommerce
force-pushed
the
quorum_queue_bugfix
branch
2 times, most recently
from
58d2a56
to
72e0495
Compare
wyardley
approved these changes
Nov 1, 2023
jimmybigcommerce
force-pushed
the
quorum_queue_bugfix
branch
from
f3dfb3d
to
29843ea
Compare
|
@wyardley I think this is all good to merge when you are ready! |
wyardley
approved these changes
Nov 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #948 - this allowed us to add policies targeted at classic_queues, quorum_queues, and streams. However after the policy is created and they are read out again in subsequent puppet runs, we get the following failure:
This modification fixes this parsing issue and adds a test which covers this change and also covers test parsing a set of alternative policy settings which aren't currently tested for (different pattern/definitions containing integer values).