Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Array values in rabbitmq_parameter #774

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

vStone
Copy link
Contributor

@vStone vStone commented Feb 7, 2019

Array (lists) are allowed values to use with rabbitmqctl.

For example: src-uri when setting up a shovel.

@wyardley could you re-review this, had to create a new pr since I have left the vrtdev organisation since the previous one :)

@vStone vStone requested a review from wyardley February 7, 2019 08:02
Array (lists) are allowed values to use with rabbitmqctl.

For example: src-uri when setting up a shovel.
@vStone vStone force-pushed the feature/parameter_arraylist branch from 3ce938e to 1fc5a66 Compare February 7, 2019 09:00
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an acceptance test with the new format as well?

@wyardley wyardley added the enhancement New feature or request label Feb 15, 2019
@wyardley
Copy link
Contributor

@vStone Given that there's a single acceptance test for this already, I'm going to assume that the new use case won't be different, hopefully that's a valid assumption.

@wyardley wyardley merged commit 5477e69 into voxpupuli:master Feb 15, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants