-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow puppetlabs/stdlib 5.x, puppet/archive 3.x and puppetlabs/apt 6.x #716
Conversation
Looks ok to me, but the acceptance test failures do seem related |
Acceptance tests depend on https://github.com/garethr/garethr-erlang which is stale |
@juniorsysadmin Is it erlang? I agree that the erlang dep thing is a nightmare and that garethr-erlang is pretty unuseful at this point. That said, isn't the actual error here related to puppet-archive version spec, or is Travis just not printing the useful part?
|
@wyardley old version of archive pulls in an old version of stdlib. I fixed it. |
gnaaaaaar. It will fail because the erlang module requires stdlib < 5. https://github.com/garethr/garethr-erlang/blob/master/metadata.json#L51 Can we get rid of the dependency to garethr-erlang? |
@bastelfreak I think the module suggests multiple ways of satisfying the erlang dep. I think there are some existing issues with garethr/erlang, but I'm not sure we can get new enough Erlang version on all platforms without it or a replacement. Some more discussion in #717 |
Interesting that travis turned green. I restarted the tests. |
@wyardley I am going to merge this and do a new release. The erlang module on the forge has no version boundaries for stdlib. |
No description provided.