Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow puppetlabs/stdlib 5.x, puppet/archive 3.x and puppetlabs/apt 6.x #716

Merged
merged 3 commits into from
Aug 29, 2018

Conversation

bastelfreak
Copy link
Member

No description provided.

@wyardley
Copy link
Contributor

Looks ok to me, but the acceptance test failures do seem related

@juniorsysadmin juniorsysadmin added enhancement New feature or request tests-fail labels Aug 27, 2018
@juniorsysadmin
Copy link
Member

juniorsysadmin commented Aug 27, 2018

Acceptance tests depend on https://github.com/garethr/garethr-erlang which is stale
See #717

@wyardley
Copy link
Contributor

@juniorsysadmin Is it erlang? I agree that the erlang dep thing is a nightmare and that garethr-erlang is pretty unuseful at this point. That said, isn't the actual error here related to puppet-archive version spec, or is Travis just not printing the useful part?

  Last 10 lines of output were:
  	Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
  	Notice: Downloading from https://forgeapi.puppet.com ...
  	Error: Could not install module 'puppet-archive' (???)
  	  No version of 'puppet-archive' can satisfy all dependencies
  	    Use `puppet module install --ignore-dependencies` to install only this module

@bastelfreak bastelfreak removed enhancement New feature or request tests-fail labels Aug 27, 2018
@bastelfreak
Copy link
Member Author

@wyardley old version of archive pulls in an old version of stdlib. I fixed it.

@bastelfreak
Copy link
Member Author

gnaaaaaar. It will fail because the erlang module requires stdlib < 5. https://github.com/garethr/garethr-erlang/blob/master/metadata.json#L51

Can we get rid of the dependency to garethr-erlang?

@bastelfreak bastelfreak changed the title allow puppetlabs/stdlib 5.x allow puppetlabs/stdlib 5.x, puppet/archive 3.x and puppetlabs/apt 6.x Aug 27, 2018
@wyardley
Copy link
Contributor

@bastelfreak I think the module suggests multiple ways of satisfying the erlang dep. I think there are some existing issues with garethr/erlang, but I'm not sure we can get new enough Erlang version on all platforms without it or a replacement. Some more discussion in #717

@bastelfreak
Copy link
Member Author

Interesting that travis turned green. I restarted the tests.

@bastelfreak
Copy link
Member Author

@wyardley I am going to merge this and do a new release. The erlang module on the forge has no version boundaries for stdlib.

@bastelfreak bastelfreak merged commit cc67103 into master Aug 29, 2018
@bastelfreak bastelfreak deleted the stdlib branch August 29, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants