Set default LC_ALL => en_US.UTF-8 (#671, #689) #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets a (somewhat US-centric) default of en_US.UTF-8 for LC_ALL in $environment_variables, to work around a warning given via Elixir in newer version of the RabbitMQ CLI tools.
|
ps - I'm also working on a better fix that would actually ignore those lines, however, doing and testing that may be more work than is ideal. We could also add some docs around this issue, though being a bit more tolerant of what the CLI tools return might be better in general? |
wyardley
added
bug
|
Thank you for this. For those interested, enforcing this in RabbitMQ CLI tool [wrappers] is under consideration rabbitmq/rabbitmq-server#1573. |
bastelfreak
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I was able to reproduce this in Vagrant (in the acceptance test environment) with some more details.
This sets a (somewhat US-centric) default of en_US.UTF-8 for LC_ALL in
$environment_variables, to work around a warning given via Elixir in newer version of the RabbitMQ CLI tools, replacing my original attempt to fix this in #690.Just
UTF-8won't work; if anyone has a suggestion for a more generic value that will still work, let me know.Some more discussion in: rabbitmq/rabbitmq-server#1573, including confirmation that the output isn't localized anyway. So I think this should be safe.
This Pull Request (PR) fixes the following issues