Fixes for Archlinux and modulesync 1.8 #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
commented
Mar 7, 2018
| @@ -254,6 +254,27 @@ | |||
| notify => Class['Rabbitmq::Service'], | |||
| } | |||
| } | |||
| 'Archlinux': { | |||
There was a problem hiding this comment.
this isn't the cleanest solution, but it works good. Later on we can think about unifying this setup for all distributions with systemd. Personally I prefer the camptocamp/systemd module for this, but maybe we need to wait for the discussion in voxpupuli/puppet-prometheus#90
There was a problem hiding this comment.
Since this isn't part of the modulesync or 'spec test fixes', does it belong in a separate PR (so that is makes it into the changelog)?
There was a problem hiding this comment.
that's why I didn't label it with modulesync. It will be in the changelog.
There was a problem hiding this comment.
To stop anyone else labelling it later, I've renamed the PR to make it a bit more obvious.
alexjfisher
changed the title
alexjfisher
approved these changes
Mar 7, 2018
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.