Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow installation of rabbitmqadmin via package #654

Merged
merged 2 commits into from
Oct 18, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Oct 18, 2017
@wyardley wyardley self-requested a review October 18, 2017 19:47
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe you could add some tests?

Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @wyardley said, needs some tests

@wyardley wyardley merged commit 05dd176 into voxpupuli:master Oct 18, 2017
@bastelfreak bastelfreak deleted the rabbitmqadmin branch October 18, 2017 22:43
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
allow installation of rabbitmqadmin via package
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being
present. It seems that, while the package exists, it is in the "community"
repo.

Partially rolls back voxpupuli#654, though continues to allow the user to set the
package via $rabbitmqadmin_package
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being
present. It seems that, while the package exists, it is in the "community"
repo.

Partially rolls back voxpupuli#654, though continues to allow the user to set the
package via $rabbitmqadmin_package
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Mar 30, 2022
Archlinux integration tests were failing because of rabbitmqadmin not being
present. It seems that, while the package exists, it is in the "community"
repo.

Update Python package name to python instead of python2

Partially rolls back voxpupuli#654, though continues to allow the user to set the
package via $rabbitmqadmin_package
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Mar 30, 2022
Update Python package name to python instead of python2, and use file install
vs. package install by default

Partially rolls back voxpupuli#654, though continues to allow the user to set the
package via $rabbitmqadmin_package
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Jun 17, 2022
Update Python package name to python instead of python2, and use file install
vs. package install by default

Partially rolls back voxpupuli#654, though continues to allow the user to set the
package via $rabbitmqadmin_package
wyardley added a commit that referenced this pull request Jun 17, 2022
Update Python package name to python instead of python2, and use file install
vs. package install by default

Partially rolls back #654, though continues to allow the user to set the
package via $rabbitmqadmin_package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants