Fix 'puppet resource rabbitmq_binding' and add tests (#650) #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #650. It also
puppet resource rabbitmq_binding
in the acceptance tests. This way, we should notice if a problem comes up with this command in the future.Since we got feedback on how to test this in the type rather than in the create method in the provider, I can try to submit a separate PR to fix this for the rabbitmq_user resource.
Some of the other providers don't have instances implemented, so won't work with
puppet resource
; this is a separate issue, though refactoring them would be a good project for someone with the time on their hands 😉