Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_expoerter v0.15.0 #70

Closed
TheMeier opened this issue Oct 18, 2017 · 2 comments · Fixed by #72
Closed

node_expoerter v0.15.0 #70

TheMeier opened this issue Oct 18, 2017 · 2 comments · Fixed by #72

Comments

@TheMeier
Copy link
Contributor

TheMeier commented Oct 18, 2017 •
edited
Loading

The release 0.15.0 of node collector changes the configuration of the collectors..

[CHANGE] Replace --collectors.enabled with per-collector flags #640

prometheus/node_exporter#640

this renders all handling as it currently is implemented of the collectors in this module useless

also #33 is propably obsoleted by this
@bastelfreak
Copy link
Member

Hi @TheMeier, thanks for the notify. Are you able to provide a PR for this?

@TheMeier
Copy link
Contributor Author

@bastelfreak actually i was considering to do so this weekend....

@TheMeier TheMeier mentioned this issue Oct 18, 2017
Merged
knackjax pushed a commit to knackjax/puppet-prometheus that referenced this issue Nov 21, 2017
@TheMeier @knackjax
node_exporter 0.15.0 compatibiity
6c6e89e 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
@TheMeier
node_exporter 0.15.0 compatibiity
187447a 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
@TheMeier
node_exporter 0.15.0 compatibiity
726c32d 
fixes voxpupuli#70
fixes voxpupuli#33

change collector parameterization to be compatible with node_exporter 0.15.0

this should be released with a major version since it breaks paramter compatinbility

for two step migration of profiles and roles using this keep node_exporter::collectors paramter as noop with deprecation warning for at least one release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

node_exporter 0.15.0 compatibiity
2 participants
@bastelfreak @TheMeier