Set default_zone and log_denied when firewalld is offline #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the exec resources that set default_zone and log_denied to fallback to the firewall-offline-cmd if firewalld is not running.
|
For what it's worth, my use case is building container images and you can see this change working at line 384 in this build log: https://gitlab.james.tl/nest/stage2/-/jobs/2349#L384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Change the exec resources that set default_zone and log_denied to fallback to the firewall-offline-cmd when firewalld is not running. This is useful, for example, in container environments or kickstart post-installs where the firewalld service can't be run but we still want these settings configured.
This Pull Request (PR) fixes the following issues
The bug this PR fixes does not have an associated issue.