Fix the firewalld_version fact #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-vaughan
force-pushed
the
fix_firewalld_version_fact
branch
from
befefc3
to
cb1ca7c
Compare
alexjfisher
reviewed
Feb 28, 2020
.rspec
Outdated
| @@ -1,2 +1,3 @@ | |||
| --format documentation | |||
| --color | |||
| --fail-fast | |||
There was a problem hiding this comment.
This will be removed by modulesync.
|
LGTM. Have you tested on both EL7 and EL8? |
alexjfisher
approved these changes
Feb 28, 2020
trevor-vaughan
force-pushed
the
fix_firewalld_version_fact
branch
from
cb1ca7c
to
88a0b86
Compare
|
@alexjfisher Yeah, it works on 7 and 8 properly. They're both in the Beaker nodeset |
trevor-vaughan
force-pushed
the
fix_firewalld_version_fact
branch
from
88a0b86
to
0c9f443
Compare
* Work around a bug in firewall-cmd and use raw python to get the firewalld version if firewalld-cmd does not return anything * Incorporated the simp-beaker-helpers gem to get access to the helper methods Fixes voxpupuli#263
trevor-vaughan
force-pushed
the
fix_firewalld_version_fact
branch
from
0c9f443
to
6ab68b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firewalld version if firewalld-cmd does not return anything
methods
Fixes #263
Pull Request (PR) description
This Pull Request (PR) fixes the following issues