check for running firewalld in custom_service::reload #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewall-cmd --reload won't work if the service is stopped. The exec-resource firewalld::reload has an "onlyif" statement, in firewalld::custom_service::reload-${name} it is missing, so I added it.
|
@domfi We don't have good tests for this module. Could you perhaps write an acceptance test. Finding someone else to confirm this works for them would also work. |
|
@ghoneycutt Relatively comprehensive acceptance tests are coming. This patch is a correct fix. |
|
Similar fix as #197. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firewall-cmd --reload won't work if the service is stopped. The exec-resource firewalld::reload has an "onlyif" statement, in firewalld::custom_service::reload-${name} it is missing, so I added it.
Pull Request (PR) description
Added an onlyif condition to firewalld::custom_service::reload to trigger only if firewalld is running. This check is already added in firewalld::reload.
This Pull Request (PR) fixes the following issues
n/a.