Use an ip range instead of looping #176
Conversation
jovandeginste
force-pushed
the
fix-ranges
branch
from
3b7bb17
to
b1f2625
Compare
|
I've had to apply this fix to our module locally in order to fix 5+ minute boot times for boxes, as the module was creating 200,000+ rules where only 6 were needed! It works well for us on CentOS 7, so consider this another vote of interest in getting this merged. :) |
|
Dear @jovandeginste, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @jovandeginste, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @jovandeginste, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
@dhoppe would you like us to fix the merge conflicts? |
|
@jovandeginste That would be great. Thank you very much. |
jovandeginste
force-pushed
the
fix-ranges
branch
from
b1f2625
to
16da593
Compare
|
@dhoppe done. |
I'm unsure why this was not yet implemented this way - I'm ready to be educated today :-)
I tested it on our servers (centos/rhel 7), this worked before I used the
puppet-firewalldmodule, and I was very surprised to find the xml file to be expanded :-)