manage_repo: ensure that we refresh the package list before installing consul #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g consul by including the hashistack_repo class, we get the correct apt repo. It will also notify the apt_update exec resource. We just need to ensure that the exec happens before we install consul.
kenyon
reviewed
Oct 26, 2022
|
https://github.com/puppetlabs/puppetlabs-apt#update-the-list-of-packages explicitly mentions the exec that should be notified/depends on. |
attachmentgenie
approved these changes
Oct 26, 2022
|
@bastelfreak ah I read that section as a description of how the module works, and considered the Exec to be an implementation detail. I was looking at this section: https://github.com/puppetlabs/puppetlabs-apt#adding-new-sources-or-ppas It's confusing at the least. I haven't been able to get apt updates to happen in the same puppet run as a package installation, consistently. |
|
It was definetly broken in many older puppetlabs-apt releases, but with the depencendy on the exec it's working fine for me since some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by including the hashistack_repo class, we get the correct apt repo. It will also notify the apt_update exec resource. We just need to ensure that the exec happens before we install consul.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues