PDK update, move CI to GH Actions #563
Conversation
|
@solarkennedy - if you are game, it would be good to enable https://github.com/apps/puppet-community-rangefinder on your modules, or just enable it for your account as it won't hurt anything (that's what I did). I am doing some debugging of CI bits on my fork and you can see its output there: genebean#1 |
genebean
force-pushed
the
general_updates
branch
11 times, most recently
from
2367f7b
to
e34a2c3
Compare
This module has long worked on Debian but it had be omitted from the list of supported OSs. This adds it to the list and also sorts the list alphabetically.
This includes many changes that are a byproduct of updating to the latest version of the PDK. All unit tests pass at this stage but several RuboCop tests still fail. Tht GH Action was copied from a Vox Pupuli module. Their module testing is pretty slick and utilizes Beaker just as this one has traditionally done so it seems like a good place to start. A couple of lines were commented out as the Gemfile from the PDK doesn't line up exactly with the one used by most Vox Pupuli modules. RuboCop is disabled for the moment as it is known that those tests do not yet pass.
genebean
changed the title
|
@solarkennedy can you take a look here as well because that's a bigger PR. |
|
Hard to review super well, but it still looks fine to me. Apparently github actions don't work yet, I guess because of the branch. |
|
It should be green now. I had the branch running in my fork - results are linked in the top comment. I’m going to start working on the rubocop bits next |
This includes many changes that are a byproduct of updating to the latest version of the PDK. All unit tests pass at this stage but several RuboCop tests still fail.
Tht GH Action was copied from a Vox Pupuli module. Their module testing is pretty slick and utilizes Beaker just as this one has traditionally done so it seems like a good place to start. A couple of lines were commented out as the Gemfile from the PDK doesn't line up exactly with the one used by most Vox Pupuli modules.
RuboCop is disabled for the moment as it is known that those tests do not yet pass.
An example of this branch and the new CI process can be seen in genebean#1
This PR is built atop #573 and includes its change.