adding the option to setup the upstream HashiCorp repository #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should default this to be true |
|
@solarkennedy not a problem, i pushed the changes requested |
…n feature for all
attachmentgenie
force-pushed
the
upstream_repo
branch
from
4374722
to
d50c07d
Compare
bastelfreak
reviewed
Jan 16, 2021
| @@ -65,6 +65,9 @@ | |||
| } | |||
| } | |||
| 'package': { | |||
| if $consul::manage_repo{ | |||
| include hashi_stack::repo | |||
There was a problem hiding this comment.
Should we also add this?
Class['hashi_stack::repo'] -> Package[ $consul::package_name]There was a problem hiding this comment.
makes sense, just pushed the update
attachmentgenie
force-pushed
the
upstream_repo
branch
from
4a5901b
to
61f3bfa
Compare
bastelfreak
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashiCorp now provides (some) upstream packages, this PR implements the managing of the repo