Fixing idempotence issues of new ACL system + improved handling of properties

[marius-meissner]

Fixes #479 and improves handling of some properties (better tracking of modifications).

SecretID of token is not displayed for security reasons. Anyway this property may be only set upon creation, so no modification tracking needed.

Feedback is highly welcome.

[marius-meissner]

Travis checks seem to fail randomly, as Consul seems to be unavailable:

Connection refused by API after 10 tries

@solarkennedy Is there a way to show the Consul log in case of a failure?

[NFarrington]

I can confirm this has fixed my use-case for the issue I reported in #479 🙂

I have spotted one other remaining idempotency issue - marking a policy or token as 'ensure => absent' always causes a notification, such as Notice: /Stage[main]/Consul_token[my-token]/ensure: removed, even if the token has already been removed

Thanks for your work on the original feature and this fix, it's helped me a lot!

[marius-meissner]

@NFarrington Thanks for the feedback!
I just adjusted the creation checks and added an acceptance test.
Could you please verify again?

[NFarrington]

All checks out on my end, looks good 👍

[solarkennedy]

Thanks @SkydiveMarius for the followup. Nice to catch these type of bugs before we make a release.
Thanks for reporting @NFarrington, just be careful using this from master :)