Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint, style, and parameter data types #476

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Lint, style, and parameter data types #476

merged 5 commits into from
Apr 12, 2019

Commits on Apr 11, 2019

  1. (maint) Lint, style, and readbilty improvements

    @natemccurdy
    natemccurdy committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    10f9e5b View commit details
    Browse the repository at this point in the history

  2. (maint) Use modern facts from the facts hash

    @natemccurdy
    natemccurdy committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    934ecde View commit details
    Browse the repository at this point in the history

  3. Fix check for missing service parameter in watch.pp

    @natemccurdy
    natemccurdy committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    02c9e0d View commit details
    Browse the repository at this point in the history

  4. Add parameter data types. Move static defaults to init.pp. 

    This commit adds parameter data types to the main classes and defines.

It also moves any static parameter defaults from params.pp to init.pp.
It's generally better to have static defaults in init.pp and leave
params.pp for any defaults that are calculated. This makes it easier to
see parameter default values when using the console in Puppet Enterprise
as well as reduces the amount of page flipping someone has to do when
casually browsing the code.
    @natemccurdy
    natemccurdy committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    317f38e View commit details
    Browse the repository at this point in the history

  5. (maint) puppet-code style fixes in README

    @natemccurdy
    natemccurdy committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    1825221 View commit details
    Browse the repository at this point in the history