-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service_config_hash to customize services #460
Conversation
manifests/service.pp
Outdated
@@ -41,6 +65,7 @@ | |||
$id = $title, | |||
$port = undef, | |||
$service_name = $title, | |||
$service_config_hash = [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a datatype to the parameter? Also in your example it's a hash, here it is an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, wasn't clear on the datatypes since some had and some don't, and there weren't any in the service manifest. All should be good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes some time to convert all old code to datatypes, but I think it should be enforced for new parameters.
@@ -41,6 +65,7 @@ | |||
$id = $title, | |||
$port = undef, | |||
$service_name = $title, | |||
Hash $service_config_hash = {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please align the =
chars and enforce the structure of the Hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alignment done, enforcement delayed per our slack conversation
Add service_config_hash to customize services
This will allow you to add new features, such as the new connect options.