Do not unquote integers with a leading zero #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integers with leading zeros are invalid in JSON, so they should probably stay quoted in. (They would be valid Javascript, but JSON does not support octal notation as stated on http://json.org.
|
Please add a test case for this. If we don't, then this particular functionality will be lost as consul_sorted_json changes. |
|
Just added tests and fixed the regex to still unquote for the case where the number is just '0'. As far as I understand, it does not fix #283 which looks for a way to keep valid integers quoted depending on key name. This PR is only about (invalid) integers with a leading zero. Sadly, it does not work the other way around either, a fix for #283 would not fix #389 . |
phaer
changed the title
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Do not unquote integers with a starting zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integers with leading zeros are invalid in JSON, so they should probably stay quoted in. (They would be valid Javascript, but JSON does not support octal notation as stated on http://json.org.
Fixes #389