Fix validate command for config files in consul 1.0.0 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consul validate command has a problem with using files which do not end in .json or .hcl which is the fact when using validate_cmd which uses a temporary file and puppet adds a tmp-specific string. This solution is kind of an ugly workaround which produces a tmp link file with the correct name and leaves it in /tmp. After the check this link will become invalid and there are no security issues.
|
This would fix Issue 376 |
|
I would also be OK if we gave up trying to do client-side validation like this. |
|
And you are actually right in suggesting this because I just found out that I introduced a nasty bug as it is now not possible to update the consul config without getting an error in puppet. |
|
Yea. I think it was a good thought, but a tad expensive and error prone. |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Fix validate command for config files in consul 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consul validate command has a problem with using files which do not end in .json or .hcl which is the fact when using validate_cmd which uses a temporary file and puppet adds a tmp-specific string. This solution is kind of an ugly workaround which produces a tmp link file with the correct name and leaves it in /tmp. After the check this link will become invalid and there are no security issues.
The consul maintainers are discussing about a better solution here hashicorp/consul#3620 but we need a solution right now and that fixed it for us. This could maybe be removed after consul adds a fix for this issue.