Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed cluster join code #29

Merged
merged 1 commit into from
Sep 26, 2014

Conversation

hkumarmk
Copy link
Contributor

Currently if initial server is not up while starting other servers or agent, the
cluster join will be failed, and unless there is any (new) service definition,
that node will not be joining to the consul cluster, until there is a service
restart as cluster join code in the is only called after service restart.
This patch will fix this issue.

Currently if initial server is not up while starting other servers or agent, the
cluster join will be failed, and unless there is any (new) service definition,
that node will not be joining to the consul cluster, until there is a service
restart as cluster join code in the is only called after service restart.
This patch will fix this issue.
@solarkennedy
Copy link
Contributor

I understand the issue.
I'm not super happy at the implementation, but I do agree that this exec should not be refreshonly.
Things change and you shouldn't have to adjust the puppet code to spark a refresh+rejoin.

I can't think of a better way to do this, so merging.

solarkennedy added a commit that referenced this pull request Sep 26, 2014
@solarkennedy solarkennedy merged commit 7c7737f into voxpupuli:master Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants