Adding in explicit support for "watches" #24
Conversation
concept introduced in consul 0.4.0 - Note: this resolves voxpupuli#23 from the puppet-consul
| $state = undef, | ||
| $event_name = undef, #Note: this actually maps to the "name" param for event watches | ||
| ) { | ||
| include consul |
There was a problem hiding this comment.
I don't know if this is a good idea.
I've seen this backfire in cases where a watch is defined first, and hence consul is "included" and then later declared twice.
I don't recommend doing this.
I think it would be safer to just validate that $consul::config_dir exists at the time you use it.
There was a problem hiding this comment.
I guess I was taking inspiration from your other two defines, the Checks and Services that used this pattern. I think I understand your suggestion and believe that is already accounted for in the bottom section, which would probably negate the need for the the explicit include. Would you like me to make similar modifications for the other two defines that are used in a similar fashion?
There was a problem hiding this comment.
Heh, no it is ok. I guess my preferences on how to construct modules has changed over time.
Adding in explicit support for "watches"
|
Thanks! This is very solid PR. Thank you for tests! |
|
Glad to help! Thanks for putting it together |
Note: this resolves #23 from the puppet-consul project