Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazily return nil when consul client isn't installed #227

Merged
merged 1 commit into from
Feb 9, 2016
Merged

lazily return nil when consul client isn't installed #227

merged 1 commit into from
Feb 9, 2016

Conversation

roobert
Copy link
Contributor

@roobert roobert commented Feb 8, 2016

This patch fixes the following error which occurs when consul isn't installed on a client:

Error: Facter: error while resolving custom fact "consul_version": undefined method `lines' for nil:NilClass

@solarkennedy
Copy link
Contributor

Thanks!

solarkennedy added a commit that referenced this pull request Feb 9, 2016
@solarkennedy
Merge pull request #227 from roobert/fix-nilclass-error-when-client-a…
02bbd18 
…bsent

lazily return nil when consul client isn't installed
@solarkennedy solarkennedy merged commit 02bbd18 into voxpupuli:master Feb 9, 2016
@solarkennedy solarkennedy mentioned this pull request Aug 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roobert @solarkennedy