Fixing gui_package install #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you have the right intent. I'm guessing the notify is for debug? You can remove that part for production otherwise it never converges. Also how about a test to make sure your logic is correct? |
|
Quickly fixed the notify already ... |
| @@ -51,7 +51,8 @@ | |||
| ensure => $consul::package_ensure, | |||
| } | |||
|
|
|||
| if $consul::ui_package_name { | |||
| # Guessing this is a bug | |||
There was a problem hiding this comment.
This is not necessary.
|
Sorry for quickly pushing my own internal fix to gh before jumping on a plane :) My internal notes didn't relaly belong there .. I'll try to find some time to write a test .. |
solarkennedy
added a commit
that referenced
this pull request
Sep 24, 2014
Fixing gui_package install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way a decision is made on installing the web_gui