fix 'consul reload' on custom rpc port

[mdelagrange]

Similar to #173.

[aj-jester]

can we just do this as part of the command?

command => "consul reload -rpc-addr=${consul::rpc_addr}:${consul::rpc_port}",

[mdelagrange]

@ericpfisher pointed out that, if we used the environment variable rather than the flag, we could probably make the init scripts cleaner.

[aj-jester]

@mdelagrange Can we add a test for the elsif? https://github.com/solarkennedy/puppet-consul/blob/master/manifests/init.pp#L133

Also it would be awesome, but not required, if we can add a test for the sysv (your previous PR) for this elsif conditional as well. I'll do the same for upstart 😄.

if we used the environment variable rather than the flag, we could probably make the init scripts cleaner.

Hmmm perhaps but I prefer if we are explicit with the flag since this module is used across various systems and I don't want something to fail because of an env var issue 😕

[mdelagrange]

OK

[mdelagrange]

All set.

[aj-jester]

@mdelagrange this looks great 👍

🚄 LGTM

[solarkennedy]

Thanks!