Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archlinux support #176

Merged
merged 2 commits into from
Aug 22, 2015
Merged

Conversation

vdloo
Copy link
Contributor

@vdloo vdloo commented Aug 22, 2015

seems to work without any other modifications

Notice: /Stage[main]/Consul::Run_service/Service[consul]/ensure: ensure changed 'stopped' to 'running'

Archlinux only has official support for systemd

Archlinux only has official support for systemd
@aj-jester
Copy link

@vdloo This is great 🎉

But a few things...

  • Can you add the supported versions of arch linux? It doesn't have to be exhaustive just what you know.
  • Can we write a unit test for this? Here is an example.

Thanks 😄

@vdloo
Copy link
Contributor Author

vdloo commented Aug 22, 2015

Sure, but because of arch's rolling release system there aren't really versions like in Debian or RedHat though. I put in the 'operatingsystemrelease' that facter returned on my system but that's just the kernel version and that can change between releases. So if the metadata.json is going to stay current it's probably going to need to be changed a couple times a month.

# facter operatingsystemrelease
4.1.5-1-ARCH

@aj-jester
Copy link

@vdloo in that case, lets do something like this.

@aj-jester
Copy link

💯

🚄 LGTM

@aj-jester aj-jester changed the title Add Archlinux to params Archlinux support Aug 22, 2015
@solarkennedy
Copy link
Contributor

Thanks!

solarkennedy added a commit that referenced this pull request Aug 22, 2015
@solarkennedy solarkennedy merged commit e6c0cde into voxpupuli:master Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants