Switch to using start-stop-daemon for consul upstart init script #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the use of sudo and permits passing the GOMAXPROCS setting via the environment. In addition this change exposes the pid file again so that other users can signal the agent. Also fixed tests Fixes #126
|
Thank you! As much as a I like the simplicity of the simple exec, I understand that the bugs are showstoppers. |
solarkennedy
added a commit
that referenced
this pull request
May 31, 2015
Switch to using start-stop-daemon for consul upstart init script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the use of sudo and permits passing the GOMAXPROCS setting
via the environment. In addition this change exposes the pid file again so
that other users can signal the agent.
Fixes #126