Release 3.2.1

[b4ldr]

Release 3.2.1

[ekohl]

@alexjfisher suggested this before, but please use Release 3.2.1 as the commit message.

[b4ldr]

updated

[ekohl]

Neither change shows up in the resulting module on the forge (since we exclude those files) so I wonder what the point of releasing this is. For comparison, I built both using rake module:build (where I was lazy and used git master):

$ diff -Nutr puppet-augeasproviders_core-3.2.0 puppet-augeasproviders_core-3.2.1-rc0
diff -Nutr puppet-augeasproviders_core-3.2.0/metadata.json puppet-augeasproviders_core-3.2.1-rc0/metadata.json
--- puppet-augeasproviders_core-3.2.0/metadata.json	2023-01-03 14:25:35.000000000 +0100
+++ puppet-augeasproviders_core-3.2.1-rc0/metadata.json	2023-01-03 14:24:01.000000000 +0100
@@ -1,6 +1,6 @@
 {
   "name": "puppet-augeasproviders_core",
-  "version": "3.2.0",
+  "version": "3.2.1-rc0",
   "author": "Vox Pupuli",
   "summary": "Alternative Augeas-based providers for Puppet",
   "license": "Apache-2.0",

[b4ldr]

@ekohl thanks, the main reason was for #43 but will ping the author of that to get more info

@lollipopman in relation to #43 how did you hit this issue, did you pull in this module from forge or git? if the later where you using a specific tag or just master?

[lollipopman]

@b4ldr & @ekohl I used g10k to pull the modules directly from github, based on the v3.2.0 tag, which is how I ran into this issue.

[lollipopman]

Actually on further reflection I hit this when trying to upgrade bodgit/puppet-postfix to v3.2.0., https://github.com/bodgit/puppet-postfix/blob/main/.fixtures.yml#L14-L17, as it pulls directly from github for its tests.

[b4ldr]

just noting also that the puppet-posfix library imports rspec files from the spec dir in this repo. This is probably not the best idea but its the reason they are not using the forge module

[lollipopman]

just noting also that the puppet-posfix library imports rspec files from the spec dir in this repo. This is probably not the best idea but its the reason they are not using the forge module

thanks @b4ldr, here is what the error looks like in CI, https://github.com/lollipopman/puppet-postfix/actions/runs/3832180811/jobs/6522193480#step:5:4355

[ekohl]

That looks like it doesn't include rspec-mocks. Perhaps it's because of https://github.com/lollipopman/puppet-postfix/blob/6fa18a696d86a6014889fd8c04e78a4b4cfb0dfd/spec/spec_helper.rb#L3-L5 which AFAIK disables rspec-mocks. I'd suggest to migrate the module to use rspec-mocks.

[ekohl]

Oh, I should also mention that it's because of 637108e where it was changed.

[lollipopman]

Oh, I should also mention that it's because of 637108e where it was changed.

Thanks @ekohl for looking at this, that commit is indeed what broke bodgit/puppet-postfix's test, as I mentioned in my pull request, aa427ad

[bastelfreak]

@b4ldr can you please rebase after #44 was merged?

[b4ldr]

@b4ldr can you please rebase after #44 was merged?

done

[h-haaks]

@b4ldr can you please rebase after #49 was merged?
And change your commit message to Release 3.2.1 as @ekohl requested.

[b4ldr]

@alexjfisher suggested this before, but please use Release 3.2.1 as the commit message.

done and rebased

[ekohl]

Can you regenerate the changelog too? The date is off and by now we've merged a real change (workaround for augeas 1.13.0 bug).

[b4ldr]

Can you regenerate the changelog too? The date is off and by now we've merged a real change (workaround for augeas 1.13.0 bug).

updated

[ekohl]

If you regen the changelog one more time that PR should have the correct label. Feel free to release it then.

[b4ldr]

updated