Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Facter 3 and older factsets #298

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

bastelfreak
Copy link
Member

Puppet 7 is the oldest supported Puppet version. It vendors Facter 4. The facterdb performance depends on the amount of factsets so it makes sense to get rid of the legacy factsets.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I'm in favor of this is faster load times at runtime.

Since we need to update the README as well and do a major version bump, perhaps it's a good time to revisit #262.

@yakatz
Copy link
Contributor

yakatz commented Mar 19, 2024

My browser was really unhappy trying to open the diff for this PR :-P
There are a few places in get_facts.sh where puppet6 is mentioned in a comment. It probably wouldn't hurt to change those to the correct strings.

@bastelfreak bastelfreak force-pushed the facter3 branch 2 times, most recently from ddd7ab6 to e71ec2b Compare May 14, 2024 10:01
@bastelfreak
Copy link
Member Author

I did a rebase. I'm not sure why some of the tests fail 🤔 someone has an idea?

@yakatz
Copy link
Contributor

yakatz commented May 14, 2024

I did a rebase. I'm not sure why some of the tests fail 🤔 someone has an idea?

When I change let(:facter_version) { '4.0.0' } to let(:facter_version) { '4.0.52' } which is the version the facts were generated with, it succeeds.

@bastelfreak
Copy link
Member Author

ah lol, yes. Thanks!

Puppet 7 is the oldest supported Puppet version. It vendors Facter 4.
The facterdb performance depends on the amount of factsets so it makes
sense to get rid of the legacy factsets.
@bastelfreak
Copy link
Member Author

IMO this is ready. I ensured that all modern facts are up2date and did a new minor release. I think we can drop the old stuff now.

@TheMeier
Copy link
Contributor

I'm ok with dropping facter 3. Puppet 7 was released over 3 years ago, puppet 6 is EOL for over a year

Copy link
Member

@binford2k binford2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the actual file changes, but in principle I'm in favor of dropping the old versions. They aren't changing, so if people need to use them, they can pin to an older release.

@bastelfreak bastelfreak merged commit 3cf5b51 into voxpupuli:master May 15, 2024
7 checks passed
@bastelfreak bastelfreak deleted the facter3 branch May 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants