Remove EOL things from fact collection and align Red Hat OSes #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
clean-up-get-facts
branch
from
f6269fe
to
c21c4a0
Compare
ghoneycutt
reviewed
Dec 14, 2021
|
This needs a rebase since some cleanups have already happened in master. However, it's low on my priority list. Anyone willing, feel free to take this over or take parts of it. |
Puppet 5 is EOL
AlmaLinux & RockyLinux are RHEL clones so it should be treated like the RH family. This is also what Facter does.
ekohl
force-pushed
the
clean-up-get-facts
branch
from
c21c4a0
to
4e69686
Compare
ekohl
changed the title
bastelfreak
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only uses package installations which simplifies the code. We can reasonably assume people don't really care about the gem based installation methods and EOL OSes.