New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate default factset files #77

Closed

glennsarti opened this issue Mar 26, 2018 · 1 comment

Contributor

glennsarti commented Mar 26, 2018

There are many duplicate files in the default fact set which serve no purpose. These should be removed and tests added to ensure they can not be re-added again.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Add duplicate factset file test

346ccf0

Previously there were many default fact files which are just duplicates.  This
commit adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.

This test is initially skipped while the duplicate files are removed in later
commits.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 11 fact sets

56051a4

This commit removes the duplicate and redundant fact sets for Solaris 11.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

783dadf

This commit removes the duplicate and redundant fact sets for Solaris 10.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

bebb4cc

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

48e0e7e

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

daf8646

This commit removes the duplicate and redundant fact sets for Solaris 10.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

583b2c3

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Add duplicate factset file test

Previously there were many default fact files which are just duplicates.  This
commit adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.

This test is initially skipped while the duplicate files are removed in later
commits.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 11 fact sets

048db00

This commit removes the duplicate and redundant fact sets for Solaris 11.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

4cfd6c9

This commit removes the duplicate and redundant fact sets for Solaris 10.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

457e1cc

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Add duplicate factset file test

11949e6

Previously there were many default fact files which are just duplicates.  This
commit adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.

This test is initially skipped while the duplicate files are removed in later
commits.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 11 fact sets

9fe1527

This commit removes the duplicate and redundant fact sets for Solaris 11.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

adbdf8b

This commit removes the duplicate and redundant fact sets for Solaris 10.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

9278c5e

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Add duplicate factset file test

51be330

Previously there were many default fact files which are just duplicates.  This
commit adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.

This test is initially skipped while the duplicate files are removed in later
commits.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 11 fact sets

6457d10

This commit removes the duplicate and redundant fact sets for Solaris 11.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

76c8031

This commit removes the duplicate and redundant fact sets for Solaris 10.

glennsarti added a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

6f71389

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Add duplicate factset file test

9f649c6

Previously there were many default fact files which are just duplicates.  This
commit adds a test will performs a simple file hash comparison of all default
factset files and fails and displays any duplicate factsets.

This test is initially skipped while the duplicate files are removed in later
commits.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 11 fact sets

69af244

This commit removes the duplicate and redundant fact sets for Solaris 11.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Remove duplicate Solaris 10 fact sets

b124509

This commit removes the duplicate and redundant fact sets for Solaris 10.

rodjek pushed a commit to glennsarti/facterdb that referenced this issue


          (voxpupuli#77) Enforce unique factsets test

112212e

Previosuly the test for unique factsets was created but skipped while the
duplicate files were removed.  Now that the files have been removed, this test
can be enforced.

rodjek added a commit that referenced this issue


          Merge pull request #79 from glennsarti/add-more-factset-tests

644d899

(#77)(#78)  Add default factset tests and fix failures

Member

rodjek commented Jul 15, 2019

Fixed by #79

rodjek closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment