Always prefer codedir for hieradata #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
requested changes
Nov 10, 2020
These tests are identical and there is no actual type check in the code so there's no benefit to testing this.
This dynamically detects the codedir on the host via the settings which should always work. The other method uses hardcoded values and can go out of sync. This is a more reliable method.
|
I also cleaned up the tests a bit so it's a bit larger. Should be in separate commits for easier review. |
dhollinger
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dynamically detects the codedir on the host via the settings which should always work. The other method uses hardcoded values and can go out of sync. This is a more reliable method.