-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T011 - Querying online API webservices #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
jaimergp
force-pushed
the
jrg-011-revamp
branch
from
January 25, 2021 14:39
944f2de
to
d186ffb
Compare
@schallerdavid This is ready for review! @yonghui-cc, this can help you understand the basics of web APIs! |
teachopencadd/talktorials/T011_query_online_api_webservices/talktorial.ipynb
Show resolved
Hide resolved
teachopencadd/talktorials/T011_query_online_api_webservices/talktorial.ipynb
Show resolved
Hide resolved
teachopencadd/talktorials/T011_query_online_api_webservices/talktorial.ipynb
Show resolved
Hide resolved
teachopencadd/talktorials/T011_query_online_api_webservices/talktorial.ipynb
Show resolved
Hide resolved
teachopencadd/talktorials/T011_query_online_api_webservices/talktorial.ipynb
Show resolved
Hide resolved
Awesome work @jaimergp , the talktorial reads very well! I only found few typos. |
And the description in the README.md is missing. |
Co-authored-by: schallerdavid <schallerdavid@users.noreply.github.com>
jaimergp
force-pushed
the
jrg-011-revamp
branch
from
January 26, 2021 10:23
32d887e
to
239fef2
Compare
Awesome @schallerdavid! Thanks for the review! |
I'll merge for now and will self-review again when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Content review
here
.DataFrames
)Code review
a_variable_name
vsaVariableName
)black -l 99
)for i in range(len(list))
(see slides)# TODO: CI
import ...
lines are at the top (practice part) cell, ordered by standard library / 3rd party packages / our own (teachopencadd.*
)