Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing packages from T001-22 to README #102

Merged
merged 4 commits into from
May 17, 2021

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented May 12, 2021

Description

Add missing packages from T001-22.

TODOs

  • README

Status

  • Ready to go

@dominiquesydow dominiquesydow changed the title Add missing packages from T001-10 to README Add missing packages from T001-22 to README May 14, 2021
@dominiquesydow dominiquesydow changed the base branch from master to t011-base May 14, 2021 11:56
@dominiquesydow
Copy link
Collaborator Author

@jaimergp I went through the talktorials and updated the external packages list.

Shall I add

  • google.colab
  • condacolab
    Those are not part of the environment, is that intentional?

@jaimergp
Copy link
Contributor

Those are installed only if running on Colab. Normal envs should not use it.

@dominiquesydow dominiquesydow changed the base branch from t011-base to master May 17, 2021 07:30
@dominiquesydow dominiquesydow changed the base branch from master to t011-base May 17, 2021 07:32
@dominiquesydow
Copy link
Collaborator Author

@jaimergp, can I merge from your side?

[`opencadd`](https://opencadd.readthedocs.io/en/latest/)
[`opencadd`](https://opencadd.readthedocs.io/en/latest/),
[`plip`](https://github.com/pharmai/plip),
[`openff`](https://github.com/openforcefield/openff-toolkit),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[`openff`](https://github.com/openforcefield/openff-toolkit),
[`openff-toolkit`](https://github.com/openforcefield/openff-toolkit),
[`openmmforcefields`](https://github.com/openmm/openmmforcefields),

We had missed this!

@jaimergp
Copy link
Contributor

@dominiquesydow Go ahead after adding my suggestion!

@dominiquesydow dominiquesydow merged commit e7c701f into t011-base May 17, 2021
@dominiquesydow dominiquesydow deleted the update-package-list branch May 17, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants