Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Some "previous" and "next" buttons are mixed up #143

Closed
dominiquesydow opened this issue Sep 9, 2021 · 13 comments · Fixed by #159
Closed

Website: Some "previous" and "next" buttons are mixed up #143

dominiquesydow opened this issue Sep 9, 2021 · 13 comments · Fixed by #159
Labels
bug Something isn't working

Comments

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Sep 9, 2021

Website: For the new talktorials, the "previous" and "next" buttons are mixed up.
Example https://projects.volkamerlab.org/teachopencadd/talktorials/T011_query_online_api_webservices.html (bottom of website):

This is not time sensitive.

@dominiquesydow dominiquesydow added the bug Something isn't working label Sep 9, 2021
@dominiquesydow
Copy link
Collaborator Author

Hi @Armin-Ariamajd, do you have experience with website design and an idea of what is responsible for the mixup?

@AAriam
Copy link
Collaborator

AAriam commented Oct 27, 2021

Hi @Armin-Ariamajd, do you have experience with website design and an idea of what is responsible for the mixup?

Hi @dominiquesydow,
I'm probably not the best person to ask, but I can certainly take a look at it.
The complete source code is the same as the one in the volkamerlab_org repository, right?

@dominiquesydow
Copy link
Collaborator Author

Hi @Armin-Ariamajd, the TeachOpenCADD website is Sphinx-based (the Volkamer Lab website uses Hugo).

@AndreaVolkamer
Copy link
Member

AndreaVolkamer commented Oct 29, 2021

@dominiquesydow and @Armin-Ariamajd I looked a bit into it and maybe it is not really - or only partly - a bug ;)

The next/previous buttons work fine in the first few pages, it actually follows the toc tree on the left.

It starts to get mixed up in the collections part. First (JCIM collection), we list T1-10 - that works fine, then (ligand-based collection) T1-7, 12, 13, 21, 22. So when moving to the second collection after T10 it skips T1-7 and directly jumps to T12 and so forth.

I feel like it has sth to do with the fact that we want to reassign for the same notebook what we consider next/previous depending on where we are, not sure if the template assigns the prev/next links once - first time they are used and keeps them static.

@jaimergp any insights on that?

@AndreaVolkamer
Copy link
Member

AndreaVolkamer commented Oct 29, 2021

While searching for the problem I only found this issue, which is somehow related in case we wanted to assign this by hand I assume?

@AndreaVolkamer
Copy link
Member

AndreaVolkamer commented Oct 29, 2021

Another question in that regard, is the level/depth of our toc correctly assigned?

In https://github.com/volkamerlab/teachopencadd/blob/master/docs/conf.py there is a globaltoc and localtoc defined (not exactly sure what they individually contain). The globaltoc depth is defined at 2 ("globaltoc_depth": 2,), should it be 3 instead?

E.g. currently we have 3 levels, no?

  • TeachOpenCADD (WIP 🚧)
  • Our talktorials
    • Talktorials by collection

      • JCIM 2019
      • Ligand-based cheminformatics
      • ...
    • Complete list of talktorials

      • T001 · Compound data acquisition (ChEMBL)
      • T002 · Molecular filtering: ADME and lead-likeness criteria
      • ...
  • Run locally

@dominiquesydow
Copy link
Collaborator Author

It starts to get mixed up in the collections part. First (JCIM collection), we list T1-10 - that works fine, then (ligand-based collection) T1-7, 12, 13, 21, 22. So when moving to the second collection after T10 it skips T1-7 and directly jumps to T12 and so forth.

I am sorry, I cannot follow.

I am starting with T001 and I scroll to the end of the page to click "Next". I repeat this for every talktorial in the sequence until I have seen all talktorials. The sequence order is the following:

  • 1-10
  • 12-13
  • 21-22
  • 14-20 (18 is missing atm)
  • 11
  • "Complete list of talktorials"

Can you describe how you saw your sequence?

@AndreaVolkamer
Copy link
Member

AndreaVolkamer commented Oct 29, 2021

I added the figure here, I'm referring to:
Let's start from the first one in the collection (so going from top to bottom in the toc tree)

  • T1-10 all fine (JCM collection)
  • now we would move to the next collection (lig.-based), so one could expect
    • either actually the overview again
    • or T01, which is the first from the second collection
    • but instead T12 is next (which is the first not yet visited one from this selection (the others were included already), then T13, T21, T22 as the collection provides
      image

So it is also a matter of what we expect, I guess if we would reorder

  • and put the 'complete list of talktorials' above the 'talktorials by collection' part
  • it might result in the behavior you would expect T01, T02, ... so all consecutive (didn't try it out though)

@dominiquesydow
Copy link
Collaborator Author

Oh, you found the pattern I see in the "next" buttons in our collection setup! Interesting!

@dominiquesydow
Copy link
Collaborator Author

dominiquesydow commented Oct 29, 2021

and put the 'complete list of talktorials' above the 'talktorials by collection' part

Just had the same thought, I will try!

@dominiquesydow
Copy link
Collaborator Author

dominiquesydow commented Oct 29, 2021

@AndreaVolkamer it works!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Thanks for spotting this!

Edit AV: YEAHHHHHHHH!!!

@dominiquesydow
Copy link
Collaborator Author

Another question in that regard, is the level/depth of our toc correctly assigned?

In https://github.com/volkamerlab/teachopencadd/blob/master/docs/conf.py there is a globaltoc and localtoc defined (not exactly sure what they individually contain). The globaltoc depth is defined at 2 ("globaltoc_depth": 2,), should it be 3 instead?

The depth seems to refer to the non-bold headers
image

and should stay at 2 otherwise we will list under each collection all the notebook titles again, which I advise against
image

@dominiquesydow
Copy link
Collaborator Author

Fixed in #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants