Skip to content

Commit

Permalink
fix(typescript): parameter hints not working on TS plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
johnsoncodehk committed Apr 18, 2024
1 parent 7373fb7 commit 5080384
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions packages/typescript/lib/node/decorateLanguageService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
isReferencesEnabled,
isRenameEnabled,
isSemanticTokensEnabled,
isSignatureHelpEnabled,
isTypeDefinitionEnabled,
} from '@volar/language-core';
import type * as ts from 'typescript';
Expand Down Expand Up @@ -67,6 +68,7 @@ export function decorateLanguageService(language: Language, languageService: ts.
getImplementationAtPosition,
getLinkedEditingRangeAtPosition,
getQuickInfoAtPosition,
getSignatureHelpItems,
getReferencesAtPosition,
getSemanticDiagnostics,
getSyntacticDiagnostics,
Expand Down Expand Up @@ -257,6 +259,27 @@ export function decorateLanguageService(language: Language, languageService: ts.
return getQuickInfoAtPosition(fileName, position);
}
};
languageService.getSignatureHelpItems = (fileName, position, options) => {
const [serviceScript, sourceScript, map] = getServiceScript(language, fileName);
if (serviceScript) {
const generatePosition = toGeneratedOffset(sourceScript, map, position, isSignatureHelpEnabled);
if (generatePosition !== undefined) {
const result = getSignatureHelpItems(fileName, generatePosition, options);
if (result) {
const applicableSpan = transformTextSpan(sourceScript, map, result.applicableSpan, isSignatureHelpEnabled);
if (applicableSpan) {
return {
...result,
applicableSpan,
};
}
}
}
}
else {
return getSignatureHelpItems(fileName, position, options);
}
};
languageService.getDocumentHighlights = (fileName, position, filesToSearch) => {
const unresolved = linkedCodeFeatureWorker(
fileName,
Expand Down

0 comments on commit 5080384

Please sign in to comment.