Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: blocaled-0.6 #51957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pondichys
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • armv7l
    • armv6l

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Aug 23, 2024
@pondichys
Copy link
Contributor Author

I have no idea why those 4 tests are failing in the pipeline as they all pass fine on both my glibc and musl void installs ... any idea how I can reproduce the environment of the CI agents locally on my workstation? I'm busy trying to reproduce the CI workflow but it's not that easy :)

@classabbyamp
Copy link
Member

did you run xbps-src with -Q?

@classabbyamp
Copy link
Member

also ci runs as root so that might be it

@pondichys
Copy link
Contributor Author

Hello @classabbyamp ,
Thanks for your feedback.

Yes I ran the package build with -Q. I'll try as root and check how it's going on.

@pondichys
Copy link
Contributor Author

pondichys commented Aug 24, 2024

Ok I found why those tests are failing. As you mentioned @classabbyamp the build is running as root. The failing tests are all related to permissions. They ensure that the service cannot write to directories the user has no access to. That runs perfectly well with a non root user but as soon as you run those as root, for sure there are no permission issues and the tests fail because the expected error does not happen.

Now, I guess that I could patch the tests to avoid the fault but if you have another idea that fits better in the usual process used for these kind of issues, I'll take it.

Once again thanks for the help.

@classabbyamp
Copy link
Member

make_check=ci-skip # some tests check permissions

@pondichys
Copy link
Contributor Author

I implemented the workaround. Many thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants